• Uros Bizjak's avatar
    nvmet: use try_cmpxchg in nvmet_update_sq_head · bbf5410b
    Uros Bizjak authored
    Use try_cmpxchg instead of cmpxchg (*ptr, old, new) == old in
    nvmet_update_sq_head.  x86 CMPXCHG instruction returns success in ZF flag, so
    this change saves a compare after cmpxchg (and related move instruction in
    front of cmpxchg).
    
    Also, try_cmpxchg implicitly assigns old *ptr value to "old" when cmpxchg
    fails. There is no need to re-read the value in the loop.
    
    Note that the value from *ptr should be read using READ_ONCE to prevent
    the compiler from merging, refetching or reordering the read.
    
    No functional change intended.
    Signed-off-by: default avatarUros Bizjak <ubizjak@gmail.com>
    Reviewed-by: default avatarSagi Grimberg <sagi@grimberg.me>
    Signed-off-by: default avatarChristoph Hellwig <hch@lst.de>
    bbf5410b
core.c 40 KB