• Matthieu Baerts's avatar
    selftests: mptcp: sockopt: relax expected returned size · 8dee6ca2
    Matthieu Baerts authored
    Selftests are supposed to run on any kernels, including the old ones not
    supporting all MPTCP features.
    
    One of them is the getsockopt(SOL_MPTCP) to get info about the MPTCP
    connections introduced by commit 55c42fa7 ("mptcp: add MPTCP_INFO
    getsockopt") and the following ones.
    
    We cannot guess in advance which sizes the kernel will returned: older
    kernel can returned smaller sizes, e.g. recently the tcp_info structure
    has been modified in commit 71fc7047 ("tcp: add rcv_wnd and
    plb_rehash to TCP_INFO") where a new field has been added.
    
    The userspace can also expect a smaller size if it is compiled with old
    uAPI kernel headers.
    
    So for these sizes, we can only check if they are above a certain
    threshold, 0 for the moment. We can also only compared sizes with the
    ones set by the kernel.
    
    Link: https://github.com/multipath-tcp/mptcp_net-next/issues/368
    Fixes: ce997912 ("selftests: mptcp: add mptcp getsockopt test cases")
    Cc: stable@vger.kernel.org
    Signed-off-by: default avatarMatthieu Baerts <matthieu.baerts@tessares.net>
    Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
    8dee6ca2
mptcp_sockopt.c 15.5 KB