• Jesper Juhl's avatar
    Fix memory leak in discard case of sctp_sf_abort_violation() · 9abed245
    Jesper Juhl authored
    In net/sctp/sm_statefuns.c::sctp_sf_abort_violation() we may leak
    the storage allocated for 'abort' by returning from the function
    without using or freeing it. This happens in case
    "sctp_auth_recv_cid(SCTP_CID_ABORT, asoc)" is true and we jump to
    the 'discard' label.
    Spotted by the Coverity checker.
    
    The simple fix is to simply move the creation of the "abort chunk"
    to after the possible jump to the 'discard' label. This way we don't
    even have to allocate the memory at all in the problem case.
    Signed-off-by: default avatarJesper Juhl <jesper.juhl@gmail.com>
    Signed-off-by: default avatarVlad Yasevich <vladislav.yasevich@hp.com>
    9abed245
sm_statefuns.c 183 KB