• John Keeping's avatar
    pinctrl/rockchip: fix gpio device creation · bceb6732
    John Keeping authored
    GPIO nodes are not themselves busses, so passing rockchip_bank_match
    here is wrong.  Passing NULL instead uses the standard bus match table
    which is more appropriate.
    
    devm_of_platform_populate() shows that this is the normal way to call
    of_platform_populate() from a device driver, so in order to match that
    more closely also add the pinctrl device as the parent for the newly
    created GPIO controllers.
    
    Specifically, using the wrong match here can break dynamic GPIO hogs as
    marking the GPIO bank as a bus means that of_platform_notify() will set
    OF_POPULATED on new child nodes and if this happens before
    of_gpio_notify() is called then the new hog will be skipped as
    OF_POPULATED is already set.
    
    Fixes: 9ce9a020 ("pinctrl/rockchip: drop the gpio related codes")
    Signed-off-by: default avatarJohn Keeping <john@metanate.com>
    Link: https://lore.kernel.org/r/20211126151352.1509583-1-john@metanate.comSigned-off-by: default avatarLinus Walleij <linus.walleij@linaro.org>
    bceb6732
pinctrl-rockchip.c 91.7 KB