• Zheng Wang's avatar
    media: bttv: fix use after free error due to btv->timeout timer · bd5b50b3
    Zheng Wang authored
    There may be some a race condition between timer function
    bttv_irq_timeout and bttv_remove. The timer is setup in
    probe and there is no timer_delete operation in remove
    function. When it hit kfree btv, the function might still be
    invoked, which will cause use after free bug.
    
    This bug is found by static analysis, it may be false positive.
    
    Fix it by adding del_timer_sync invoking to the remove function.
    
    cpu0                cpu1
                      bttv_probe
                        ->timer_setup
                          ->bttv_set_dma
                            ->mod_timer;
    bttv_remove
      ->kfree(btv);
                      ->bttv_irq_timeout
                        ->USE btv
    
    Fixes: 162e6376 ("media: pci: Convert timers to use timer_setup()")
    Signed-off-by: default avatarZheng Wang <zyytlz.wz@163.com>
    Signed-off-by: default avatarHans Verkuil <hverkuil-cisco@xs4all.nl>
    bd5b50b3
bttv-driver.c 96 KB