• Stephan Gerhold's avatar
    clk: qcom: gcc-msm8909: Increase delay for USB PHY reset · dcc6c9fb
    Stephan Gerhold authored
    The USB PHY on MSM8909 works with the driver used on MSM8916
    (phy-qcom-usb-hs.c). When turning the PHY on/off it is first reset
    using the standard reset controller API. On MSM8916 the reset is
    provided by the USB driver (ci_hdrc_msm_por_reset() in ci_hdrc_msm.c).
    
    While this seems to work on MSM8909 as well, the Qualcomm Linux sources
    suggest that the PHY should be reset using the GCC_USB2_HS_PHY_ONLY_BCR
    register instead. In general this is easy to set up in the device tree,
    thanks to the standard reset controller API.
    
    However, to conform to the specifications of the PHY the reset signal
    should be asserted for at least 10 us. This is handled correctly on
    MSM8916 in ci_hdrc_msm_por_reset(), but not within the GCC driver.
    
    Fix this by making use of the new "udelay" field of qcom_reset_map
    and set a delay of ~15 us between the assertion/deassertion of the
    USB PHY reset signal.
    Signed-off-by: default avatarStephan Gerhold <stephan.gerhold@kernkonzept.com>
    Signed-off-by: default avatarBjorn Andersson <andersson@kernel.org>
    Link: https://lore.kernel.org/r/20220706134132.3623415-5-stephan.gerhold@kernkonzept.com
    dcc6c9fb
gcc-msm8909.c 67 KB