• Rafael J. Wysocki's avatar
    thermal: sysfs: Rework the handling of trip point updates · be0a3600
    Rafael J. Wysocki authored
    Both trip_point_temp_store() and trip_point_hyst_store() use
    thermal_zone_set_trip() to update a given trip point, but none of them
    actually needs to change more than one field in struct thermal_trip
    representing it.  However, each of them effectively calls
    __thermal_zone_get_trip() twice in a row for the same trip index value,
    once directly and once via thermal_zone_set_trip(), which is not
    particularly efficient, and the way in which thermal_zone_set_trip()
    carries out the update is not particularly straightforward.
    
    Moreover, input processing need not be done under the thermal zone lock
    in any of these functions.
    
    Rework trip_point_temp_store() and trip_point_hyst_store() to address
    the above, move the part of thermal_zone_set_trip() that is still
    useful to a new function called thermal_zone_trip_updated() and drop
    the rest of it.
    
    While at it, make trip_point_hyst_store() reject negative hysteresis
    values.
    Signed-off-by: default avatarRafael J. Wysocki <rafael.j.wysocki@intel.com>
    Reviewed-by: default avatarDaniel Lezcano <daniel.lezcano@linaro.org>
    be0a3600
thermal_core.h 5.47 KB