• Jason Low's avatar
    locking/mutex: Refactor mutex_spin_on_owner() · be1f7bf2
    Jason Low authored
    As suggested by Davidlohr, we could refactor mutex_spin_on_owner().
    
    Currently, we split up owner_running() with mutex_spin_on_owner().
    When the owner changes, we make duplicate owner checks which are not
    necessary. It also makes the code a bit obscure as we are using a
    second check to figure out why we broke out of the loop.
    
    This patch modifies it such that we remove the owner_running() function
    and the mutex_spin_on_owner() loop directly checks for if the owner changes,
    if the owner is not running, or if we need to reschedule. If the owner
    changes, we break out of the loop and return true. If the owner is not
    running or if we need to reschedule, then break out of the loop and return
    false.
    Suggested-by: default avatarDavidlohr Bueso <dave@stgolabs.net>
    Signed-off-by: default avatarJason Low <jason.low2@hp.com>
    Signed-off-by: default avatarPeter Zijlstra (Intel) <peterz@infradead.org>
    Cc: Aswin Chandramouleeswaran <aswin@hp.com>
    Cc: Linus Torvalds <torvalds@linux-foundation.org>
    Cc: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
    Cc: Tim Chen <tim.c.chen@linux.intel.com>
    Cc: chegu_vinod@hp.com
    Cc: tglx@linutronix.de
    Link: http://lkml.kernel.org/r/1422914367-5574-3-git-send-email-jason.low2@hp.comSigned-off-by: default avatarIngo Molnar <mingo@kernel.org>
    be1f7bf2
mutex.c 25.2 KB