• Anirudh Venkataramanan's avatar
    cassini: Use memcpy_from_page() instead of k[un]map_atomic() · e3128591
    Anirudh Venkataramanan authored
    kmap_atomic() is being deprecated in favor of kmap_local_page(). Replace
    the map-memcpy-unmap usage pattern (done using k[un]map_atomic()) with
    memcpy_from_page(), which internally uses kmap_local_page() and
    kunmap_local(). This renders the variable 'vaddr' unnecessary, and so
    remove this too.
    
    Note that kmap_atomic() disables preemption and page-fault processing, but
    kmap_local_page() doesn't. When converting uses of kmap_atomic(), one has
    to check if the code being executed between the map/unmap implicitly
    depends on page-faults and/or preemption being disabled. If yes, then code
    to disable page-faults and/or preemption should also be added for
    functional correctness. That however doesn't appear to be the case here,
    so just memcpy_from_page() is used.
    
    Also note that the page being mapped is not allocated by the driver, and so
    the driver doesn't know if the page is in normal memory. This is the reason
    kmap_local_page() is used (via memcpy_from_page()) as opposed to
    page_address().
    
    I don't have hardware, so this change has only been compile tested.
    
    Cc: Ira Weiny <ira.weiny@intel.com>
    Cc: Fabio M. De Francesco <fmdefrancesco@gmail.com>
    Suggested-by: default avatarFabio M. De Francesco <fmdefrancesco@gmail.com>
    Signed-off-by: default avatarAnirudh Venkataramanan <anirudh.venkataramanan@intel.com>
    Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
    e3128591
cassini.c 137 KB