• Kees Cook's avatar
    x86/boot: Make memcpy() handle overlaps · bf0118db
    Kees Cook authored
    Two uses of memcpy() (screen scrolling and ELF parsing) were handling
    overlapping memory areas. While there were no explicitly noticed bugs
    here (yet), it is best to fix this so that the copying will always be
    safe.
    
    Instead of making a new memmove() function that might collide with other
    memmove() definitions in the decompressors, this just makes the compressed
    boot code's copy of memcpy() overlap-safe.
    Suggested-by: default avatarLasse Collin <lasse.collin@tukaani.org>
    Reported-by: default avatarYinghai Lu <yinghai@kernel.org>
    Signed-off-by: default avatarKees Cook <keescook@chromium.org>
    Cc: Andrew Morton <akpm@linux-foundation.org>
    Cc: Andrey Ryabinin <aryabinin@virtuozzo.com>
    Cc: Andy Lutomirski <luto@amacapital.net>
    Cc: Andy Lutomirski <luto@kernel.org>
    Cc: Baoquan He <bhe@redhat.com>
    Cc: Borislav Petkov <bp@alien8.de>
    Cc: Borislav Petkov <bp@suse.de>
    Cc: Brian Gerst <brgerst@gmail.com>
    Cc: Denys Vlasenko <dvlasenk@redhat.com>
    Cc: Dmitry Vyukov <dvyukov@google.com>
    Cc: H. Peter Anvin <hpa@zytor.com>
    Cc: H.J. Lu <hjl.tools@gmail.com>
    Cc: Josh Poimboeuf <jpoimboe@redhat.com>
    Cc: Linus Torvalds <torvalds@linux-foundation.org>
    Cc: Peter Zijlstra <peterz@infradead.org>
    Cc: Thomas Gleixner <tglx@linutronix.de>
    Link: http://lkml.kernel.org/r/1461185746-8017-5-git-send-email-keescook@chromium.orgSigned-off-by: default avatarIngo Molnar <mingo@kernel.org>
    bf0118db
misc.c 9.44 KB