• Anton Vorontsov's avatar
    netdev: bunch of drivers: avoid WARN at net/core/dev.c:1328 · c8f15686
    Anton Vorontsov authored
    The drivers were touching net queue before it has been started, so
    without this patch, the drivers will potentially WARN at
    net/core/dev.c:1328.
    
    I don't have the hardware for the drivers below, so this patch is
    untested, and thus should be carefully peer reviewed.
    
    tc35815.c
    au1000_eth.c
    bfin_mac.c
    macb.c
    ^ The four drivers are using phylib, they're calling netif_start_queue()
    in open() callback. So trivially remove netif_tx_schedule_all().
    Phylib will handle netif_carrier_*().
    
    cpmac.c
    fec_mpc52xx.c
    fs_enet/fs_enet-main.c
    sh_eth.c
    ^ The same as above, but these were also needlessly calling
    netif_carrier_*() functions. So removed queue calls and also remove
    carrier calls, since phylib will handle it. fs_enet-main.c also didn't
    call netif_start_queue() at open(), this is fixed now.
    Signed-off-by: default avatarAnton Vorontsov <avorontsov@ru.mvista.com>
    Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
    c8f15686
sh_eth.c 28.9 KB