• Qu Wenruo's avatar
    btrfs: reduce extent threshold for autodefrag · 558732df
    Qu Wenruo authored
    There is a big gap between inode_should_defrag() and autodefrag extent
    size threshold.  For inode_should_defrag() it has a flexible
    @small_write value. For compressed extent is 16K, and for non-compressed
    extent it's 64K.
    
    However for autodefrag extent size threshold, it's always fixed to the
    default value (256K).
    
    This means, the following write sequence will trigger autodefrag to
    defrag ranges which didn't trigger autodefrag:
    
      pwrite 0 8k
      sync
      pwrite 8k 128K
      sync
    
    The latter 128K write will also be considered as a defrag target (if
    other conditions are met). While only that 8K write is really
    triggering autodefrag.
    
    Such behavior can cause extra IO for autodefrag.
    
    Close the gap, by copying the @small_write value into inode_defrag, so
    that later autodefrag can use the same @small_write value which
    triggered autodefrag.
    
    With the existing transid value, this allows autodefrag really to scan
    the ranges which triggered autodefrag.
    
    Although this behavior change is mostly reducing the extent_thresh value
    for autodefrag, I believe in the future we should allow users to specify
    the autodefrag extent threshold through mount options, but that's an
    other problem to consider in the future.
    
    CC: stable@vger.kernel.org # 5.16+
    Signed-off-by: default avatarQu Wenruo <wqu@suse.com>
    Signed-off-by: default avatarDavid Sterba <dsterba@suse.com>
    558732df
inode.c 300 KB