• Dave Chinner's avatar
    xfs: don't assert fail on transaction cancel with deferred ops · 55d5c3a3
    Dave Chinner authored
    We can error out of an allocation transaction when updating BMBT
    blocks when things go wrong. This can be a btree corruption, and
    unexpected ENOSPC, etc. In these cases, we already have deferred ops
    queued for the first allocation that has been done, and we just want
    to cancel out the transaction and shut down the filesystem on error.
    
    In fact, we do just that for production systems - the assert that we
    can't have a transaction with defer ops attached unless we are
    already shut down is bogus and gets in the way of debugging
    whatever issue is actually causing the transaction to be cancelled.
    
    Remove the assert because it is causing spurious test failures to
    hang test machines.
    Signed-off-by: default avatarDave Chinner <dchinner@redhat.com>
    Reviewed-by: default avatarAllison Henderson <allison.henderson@oracle.com>
    Reviewed-by: default avatarDarrick J. Wong <djwong@kernel.org>
    55d5c3a3
xfs_trans.c 38.7 KB