• Randy Dunlap's avatar
    NFS: fs_context: validate UDP retrans to prevent shift out-of-bounds · c09f11ef
    Randy Dunlap authored
    Fix shift out-of-bounds in xprt_calc_majortimeo(). This is caused
    by a garbage timeout (retrans) mount option being passed to nfs mount,
    in this case from syzkaller.
    
    If the protocol is XPRT_TRANSPORT_UDP, then 'retrans' is a shift
    value for a 64-bit long integer, so 'retrans' cannot be >= 64.
    If it is >= 64, fail the mount and return an error.
    
    Fixes: 9954bf92
    
     ("NFS: Move mount parameterisation bits into their own file")
    Reported-by: syzbot+ba2e91df8f74809417fa@syzkaller.appspotmail.com
    Reported-by: syzbot+f3a0fa110fd630ab56c8@syzkaller.appspotmail.com
    Signed-off-by: default avatarRandy Dunlap <rdunlap@infradead.org>
    Cc: Trond Myklebust <trond.myklebust@hammerspace.com>
    Cc: Anna Schumaker <anna.schumaker@netapp.com>
    Cc: linux-nfs@vger.kernel.org
    Cc: David Howells <dhowells@redhat.com>
    Cc: Al Viro <viro@zeniv.linux.org.uk>
    Cc: stable@vger.kernel.org
    Signed-off-by: default avatarTrond Myklebust <trond.myklebust@hammerspace.com>
    c09f11ef
fs_context.c 39 KB