• Florian Fainelli's avatar
    firmware: arm_scmi: Give SMC transport precedence over mailbox · db8f0b80
    Florian Fainelli authored
    Broadcom STB platforms have for historical reasons included both
    "arm,scmi-smc" and "arm,scmi" in their SCMI Device Tree node compatible
    string, in that order.
    
    After the commit b53515fa ("firmware: arm_scmi: Make MBOX transport
    a standalone driver") and with a kernel configuration that enables both
    the SMC and the mailbox transports, we would probe the mailbox transport,
    but fail to complete since we would not have a mailbox driver available.
    
    With each SCMI transport being a platform driver with its own set of
    compatible strings to match, rather than an unique platform driver entry
    point, we no longer match from most specific to least specific. There is
    also no simple way for the mailbox driver to return -ENODEV and let
    another platform driver attempt probing. This leads to a platform with
    no SCMI provider, therefore all drivers depending upon SCMI resources
    are put on deferred probe forever.
    
    By keeping the SMC transport objects linked first, we can let the
    platform driver match the compatible string and probe successfully with
    no adverse effects on platforms using the mailbox transport.
    
    This is just the workaround to the issue observed which doesn't have any
    impact on the other platforms.
    
    Fixes: b53515fa ("firmware: arm_scmi: Make MBOX transport a standalone driver")
    Signed-off-by: default avatarFlorian Fainelli <florian.fainelli@broadcom.com>
    Message-Id: <20241007235413.507860-1-florian.fainelli@broadcom.com>
    Reviewed-by: default avatarCristian Marussi <cristian.marussi@arm.com>
    Signed-off-by: default avatarSudeep Holla <sudeep.holla@arm.com>
    db8f0b80
Makefile 845 Bytes