• Damian Muszynski's avatar
    crypto: qat - change SLAs cleanup flow at shutdown · c2304e1a
    Damian Muszynski authored
    The implementation of the Rate Limiting (RL) feature includes the cleanup
    of all SLAs during device shutdown. For each SLA, the firmware is notified
    of the removal through an admin message, the data structures that take
    into account the budgets are updated and the memory is freed.
    However, this explicit cleanup is not necessary as (1) the device is
    reset, and the firmware state is lost and (2) all RL data structures
    are freed anyway.
    
    In addition, if the device is unresponsive, for example after a PCI
    AER error is detected, the admin interface might not be available.
    This might slow down the shutdown sequence and cause a timeout in
    the recovery flows which in turn makes the driver believe that the
    device is not recoverable.
    
    Fix by replacing the explicit SLAs removal with just a free of the
    SLA data structures.
    
    Fixes: d9fb8408 ("crypto: qat - add rate limiting feature to qat_4xxx")
    Cc: <stable@vger.kernel.org>
    Signed-off-by: default avatarDamian Muszynski <damian.muszynski@intel.com>
    Reviewed-by: default avatarGiovanni Cabiddu <giovanni.cabiddu@intel.com>
    Signed-off-by: default avatarHerbert Xu <herbert@gondor.apana.org.au>
    c2304e1a
adf_rl.c 29.5 KB