• Chengming Zhou's avatar
    mm/zswap: only support zswap_exclusive_loads_enabled · c2e2ba77
    Chengming Zhou authored
    The !zswap_exclusive_loads_enabled mode will leave compressed copy in
    the zswap tree and lru list after the folio swapin.
    
    There are some disadvantages in this mode:
    1. It's a waste of memory since there are two copies of data, one is
       folio, the other one is compressed data in zswap. And it's unlikely
       the compressed data is useful in the near future.
    
    2. If that folio is dirtied, the compressed data must be not useful,
       but we don't know and don't invalidate the trashy memory in zswap.
    
    3. It's not reclaimable from zswap shrinker since zswap_writeback_entry()
       will always return -EEXIST and terminate the shrinking process.
    
    On the other hand, the only downside of zswap_exclusive_loads_enabled
    is a little more cpu usage/latency when compression, and the same if
    the folio is removed from swapcache or dirtied.
    
    More explanation by Johannes on why we should consider exclusive load
    as the default for zswap:
    
      Caching "swapout work" is helpful when the system is thrashing. Then
      recently swapped in pages might get swapped out again very soon. It
      certainly makes sense with conventional swap, because keeping a clean
      copy on the disk saves IO work and doesn't cost any additional memory.
    
      But with zswap, it's different. It saves some compression work on a
      thrashing page. But the act of keeping compressed memory contributes
      to a higher rate of thrashing. And that can cause IO in other places
      like zswap writeback and file memory.
    
    And the A/B test results of the kernel build in tmpfs with limited memory
    can support this theory:
    
    			!exclusive	exclusive
    real                       63.80         63.01
    user                       1063.83       1061.32
    sys                        290.31        266.15
    
    workingset_refault_anon    2383084.40    1976397.40
    workingset_refault_file    44134.00      45689.40
    workingset_activate_anon   837878.00     728441.20
    workingset_activate_file   4710.00       4085.20
    workingset_restore_anon    732622.60     639428.40
    workingset_restore_file    1007.00       926.80
    workingset_nodereclaim     0.00          0.00
    pgscan                     14343003.40   12409570.20
    pgscan_kswapd              0.00          0.00
    pgscan_direct              14343003.40   12409570.20
    pgscan_khugepaged          0.00          0.00
    
    Link: https://lkml.kernel.org/r/20240201-b4-zswap-invalidate-entry-v2-5-99d4084260a0@bytedance.comSigned-off-by: default avatarChengming Zhou <zhouchengming@bytedance.com>
    Acked-by: default avatarYosry Ahmed <yosryahmed@google.com>
    Acked-by: default avatarJohannes Weiner <hannes@cmpxchg.org>
    Reviewed-by: default avatarNhat Pham <nphamcs@gmail.com>
    Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
    c2e2ba77
Kconfig 38.4 KB