• Masahiro Yamada's avatar
    arm64: remove unneeded copy to init_utsname()->machine · c2f0b54f
    Masahiro Yamada authored
    As you see in init/version.c, init_uts_ns.name.machine is initially
    set to UTS_MACHINE.  There is no point to copy the same string.
    
    I dug the git history to figure out why this line is here.  My best
    guess is like this:
    
     - This line has been around here since the initial support of arm64
       by commit 9703d9d7 ("arm64: Kernel booting and initialisation").
       If ARCH (=arm64) and UTS_MACHINE (=aarch64) do not match,
       arch/$(ARCH)/Makefile is supposed to override UTS_MACHINE, but the
       initial version of arch/arm64/Makefile missed to do that.  Instead,
       the boot code copied "aarch64" to init_utsname()->machine.
    
     - Commit 94ed1f2c ("arm64: setup: report ELF_PLATFORM as the
       machine for utsname") replaced "aarch64" with ELF_PLATFORM to
       make "uname" to reflect the endianness.
    
     - ELF_PLATFORM does not help to provide the UTS machine name to rpm
       target, so commit cfa88c79 ("arm64: Set UTS_MACHINE in the
       Makefile") fixed it.  The commit simply replaced ELF_PLATFORM with
       UTS_MACHINE, but missed the fact the string copy itself is no longer
       needed.
    Signed-off-by: default avatarMasahiro Yamada <yamada.masahiro@socionext.com>
    Signed-off-by: default avatarWill Deacon <will.deacon@arm.com>
    c2f0b54f
Makefile 2.43 KB