• Mike Christie's avatar
    vhost-scsi: drop flush after vhost_dev_cleanup · c3d284cf
    Mike Christie authored
    The flush after vhost_dev_cleanup is not needed because:
    
    1. It doesn't do anything. vhost_dev_cleanup will stop the worker thread
    so the flush call will just return since the worker has not device.
    
    2. It's not needed for the re-queue case. vhost_scsi_evt_handle_kick grabs
    the mutex and if the backend is NULL will return without queueing a work.
    vhost_scsi_clear_endpoint will set the backend to NULL under the vq->mutex
    then drops the mutex and does a flush. So we know when
    vhost_scsi_clear_endpoint has dropped the mutex after clearing the backend
    no evt related work will be able to requeue. The flush would then make sure
    any queued evts are run and return.
    Signed-off-by: default avatarMike Christie <michael.christie@oracle.com>
    Acked-by: default avatarJason Wang <jasowang@redhat.com>
    Message-Id: <20220517180850.198915-7-michael.christie@oracle.com>
    Signed-off-by: default avatarMichael S. Tsirkin <mst@redhat.com>
    c3d284cf
scsi.c 64 KB