• Evan Green's avatar
    RISC-V: hwprobe: Add MISALIGNED_PERF key · c42e2f07
    Evan Green authored
    RISCV_HWPROBE_KEY_CPUPERF_0 was mistakenly flagged as a bitmask in
    hwprobe_key_is_bitmask(), when in reality it was an enum value. This
    causes problems when used in conjunction with RISCV_HWPROBE_WHICH_CPUS,
    since SLOW, FAST, and EMULATED have values whose bits overlap with
    each other. If the caller asked for the set of CPUs that was SLOW or
    EMULATED, the returned set would also include CPUs that were FAST.
    
    Introduce a new hwprobe key, RISCV_HWPROBE_KEY_MISALIGNED_PERF, which
    returns the same values in response to a direct query (with no flags),
    but is properly handled as an enumerated value. As a result, SLOW,
    FAST, and EMULATED are all correctly treated as distinct values under
    the new key when queried with the WHICH_CPUS flag.
    
    Leave the old key in place to avoid disturbing applications which may
    have already come to rely on the key, with or without its broken
    behavior with respect to the WHICH_CPUS flag.
    
    Fixes: e178bf14 ("RISC-V: hwprobe: Introduce which-cpus flag")
    Signed-off-by: default avatarEvan Green <evan@rivosinc.com>
    Reviewed-by: default avatarCharlie Jenkins <charlie@rivosinc.com>
    Reviewed-by: default avatarAndrew Jones <ajones@ventanamicro.com>
    Link: https://lore.kernel.org/r/20240809214444.3257596-2-evan@rivosinc.comSigned-off-by: default avatarPalmer Dabbelt <palmer@rivosinc.com>
    c42e2f07
hwprobe.rst 13.2 KB