• Jeff Layton's avatar
    nfsd: only set file_lock.fl_lmops in nfsd4_lockt if a stateowner is found · fa82a491
    Jeff Layton authored
    nfsd4_lockt does a search for a lockstateowner when building the lock
    struct to test. If one is found, it'll set fl_owner to it. Regardless of
    whether that happens, it'll also set fl_lmops. Given that this lock is
    basically a "lightweight" lock that's just used for checking conflicts,
    setting fl_lmops is probably not appropriate for it.
    
    This behavior exposed a bug in DLM's GETLK implementation where it
    wasn't clearing out the fields in the file_lock before filling in
    conflicting lock info. While we were able to fix this in DLM, it
    still seems pointless and dangerous to set the fl_lmops this way
    when we may have a NULL lockstateowner.
    Signed-off-by: default avatarJeff Layton <jlayton@redhat.com>
    Signed-off-by: default avatarJ. Bruce Fields <bfields@pig.fieldses.org>
    fa82a491
nfs4state.c 87 KB