• Johan Hovold's avatar
    net: ethernet: ti: cpsw: fix bad register access in probe error path · c46ab7e0
    Johan Hovold authored
    Make sure to keep the platform device runtime-resumed throughout probe
    to avoid accessing the CPSW registers in the error path (e.g. for
    deferred probe) with clocks disabled:
    
    Unhandled fault: external abort on non-linefetch (0x1008) at 0xd0872d08
    ...
    [<c04fabcc>] (cpsw_ale_control_set) from [<c04fb8b4>] (cpsw_ale_destroy+0x2c/0x44)
    [<c04fb8b4>] (cpsw_ale_destroy) from [<c04fea58>] (cpsw_probe+0xbd0/0x10c4)
    [<c04fea58>] (cpsw_probe) from [<c047b2a0>] (platform_drv_probe+0x5c/0xc0)
    
    Fixes: df828598 ("netdev: driver: ethernet: Add TI CPSW driver")
    Signed-off-by: default avatarJohan Hovold <johan@kernel.org>
    Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
    c46ab7e0
cpsw.c 76.8 KB