• Roland Dreier's avatar
    cxgb3: Fix sparse warning and micro-optimize is_pure_response() · c5419e6f
    Roland Dreier authored
    The function is_pure_response() does "ntohl(var) & const" and then
    essentially just tests whether the result is 0 or not; this can be done
    more efficiently by computing "var & htonl(const)" instead and doing the
    byte swap at compile time instead of run time.
    
    This change slightly shrinks the compiled code; eg on x86-64 we save a
    couple of bswapl instructions:
    
    add/remove: 0/0 grow/shrink: 0/1 up/down: 0/-8 (-8)
    function                                     old     new   delta
    t3_sge_intr_msix_napi                        544     536      -8
    
    and this also has the pleasant side effect of fixing a sparse warning:
    
        drivers/net/cxgb3/sge.c:2313:15: warning: restricted degrades to integer
    Signed-off-by: default avatarRoland Dreier <rolandd@cisco.com>
    Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
    c5419e6f
sge.c 89.1 KB