net/core/ethtool.c · c590b5e2f05b5e98e614382582b7ae4cddb37599 · Kirill Smelkov / linux

You need to sign in or sign up before continuing.

ethtool: make .get_dump_data() harder to misuse by drivers · c590b5e2

Michal Schmidt authored Jul 01, 2013



As the patch "bnx2x: remove zeroing of dump data buffer" showed,
it is too easy implement .get_dump_data incorrectly in a driver.

Let's make sure drivers cannot get confused by userspace requesting
a too big dump.

Also WARN if the driver sets dump->len to something weird and make
sure the length reported to userspace is the actual length of data
copied to userspace.
Signed-off-by: Michal Schmidt <mschmidt@redhat.com>
Reviewed-by: Ben Hutchings <ben@decadent.org.uk>
Signed-off-by: David S. Miller <davem@davemloft.net>

c590b5e2

ethtool.c 39.9 KB

Replace ethtool.c