• David Hildenbrand's avatar
    mm/rmap: move folio_test_anon() check out of __folio_set_anon() · c5c54003
    David Hildenbrand authored
    Let's handle it in the caller; no need for the "first" check based on the
    mapcount.
    
    We really only end up with !anon pages in page_add_anon_rmap() via
    do_swap_page(), where we hold the folio lock.  So races are not possible. 
    Add a VM_WARN_ON_FOLIO() to make sure that we really hold the folio lock.
    
    In the future, we might want to let do_swap_page() use
    folio_add_new_anon_rmap() on new pages instead: however, we might have to
    pass then whether the folio is exclusive or not.  So keep it in there for
    now.
    
    For hugetlb we never expect to have a non-anon page in
    hugepage_add_anon_rmap().  Remove that code, along with some other checks
    that are either not required or were checked in
    hugepage_add_new_anon_rmap() already.
    
    Link: https://lkml.kernel.org/r/20230913125113.313322-4-david@redhat.comSigned-off-by: default avatarDavid Hildenbrand <david@redhat.com>
    Cc: Matthew Wilcox <willy@infradead.org>
    Cc: Mike Kravetz <mike.kravetz@oracle.com>
    Cc: Muchun Song <muchun.song@linux.dev>
    Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
    c5c54003
rmap.c 73.6 KB