• Florian Fainelli's avatar
    net: bcmgenet: update UMAC_CMD only when link is detected · c677ba8b
    Florian Fainelli authored
    When we bring the interface down, phy_stop() will schedule the PHY state
    machine to call our link adjustment callback. By the time we do so, we
    may have clock gated off the GENET hardware block, and this will cause
    bus errors to happen in bcmgenet_mii_setup():
    
    Make sure that we only touch the UMAC_CMD register when there is an
    actual link. This is safe to do for two reasons:
    
    - updating the Ethernet MAC registers only make sense when a physical
      link is present
    - the PHY library state machine first set phydev->link = 0 before
      invoking phydev->adjust_link in the PHY_HALTED case
    
    Fixes: 24052408 ("net: bcmgenet: only update UMAC_CMD if something changed")
    Signed-off-by: default avatarFlorian Fainelli <f.fainelli@gmail.com>
    Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
    c677ba8b
bcmmii.c 11.4 KB