• Herbert Xu's avatar
    rhashtable: Fix walker list corruption · c6ff5268
    Herbert Xu authored
    The commit ba7c95ea ("rhashtable:
    Fix sleeping inside RCU critical section in walk_stop") introduced
    a new spinlock for the walker list.  However, it did not convert
    all existing users of the list over to the new spin lock.  Some
    continued to use the old mutext for this purpose.  This obviously
    led to corruption of the list.
    
    The fix is to use the spin lock everywhere where we touch the list.
    
    This also allows us to do rcu_rad_lock before we take the lock in
    rhashtable_walk_start.  With the old mutex this would've deadlocked
    but it's safe with the new spin lock.
    
    Fixes: ba7c95ea ("rhashtable: Fix sleeping inside RCU...")
    Reported-by: default avatarColin Ian King <colin.king@canonical.com>
    Signed-off-by: default avatarHerbert Xu <herbert@gondor.apana.org.au>
    Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
    c6ff5268
rhashtable.c 20.6 KB