• Arnaldo Carvalho de Melo's avatar
    perf tests record: Fail the test if the 'errs' counter is not zero · 25c5e67c
    Arnaldo Carvalho de Melo authored
    We were just checking for the 'err' variable, when we should really see
    if there was some of the many checked errors that don't stop the test
    right away.
    
    Detected with clang 15.0.0:
    
      44    75.23 fedora:37       : FAIL clang version 15.0.0 (Fedora 15.0.0-2.fc37)
    
        tests/perf-record.c:68:16: error: variable 'errs' set but not used [-Werror,-Wunused-but-set-variable]
                int err = -1, errs = 0, i, wakeups = 0;
                              ^
        1 error generated.
    
    The patch introducing this 'perf test' entry had that check:
    
      +       return (err < 0 || errs > 0) ? -1 : 0;
    
    But at some point we lost that:
    
      -	  return (err < 0 || errs > 0) ? -1 : 0;
      +	  if (err == -EACCES)
      +               return TEST_SKIP;
      +	  if (err < 0)
      +               return TEST_FAIL;
      +	  return TEST_OK
    
    Put it back.
    
    Fixes: 2cf88f46 ("perf test: Use skip in PERF_RECORD_*")
    Acked-by: default avatarIan Rogers <irogers@google.com>
    Cc: Adrian Hunter <adrian.hunter@intel.com>
    Cc: Jiri Olsa <jolsa@kernel.org>
    Cc: Namhyung Kim <namhyung@kernel.org>
    Link: https://lore.kernel.org/lkml/YzR0n5QhsH9VyYB0@kernel.orgSigned-off-by: default avatarArnaldo Carvalho de Melo <acme@redhat.com>
    25c5e67c
perf-record.c 8.74 KB