• Fabio M. De Francesco's avatar
    hfs: replace kmap() with kmap_local_page() in bnode.c · ca0ac8df
    Fabio M. De Francesco authored
    kmap() is being deprecated in favor of kmap_local_page().
    
    Two main problems with kmap(): (1) It comes with an overhead as mapping
    space is restricted and protected by a global lock for synchronization and
    (2) it also requires global TLB invalidation when the kmap's pool wraps
    and it might block when the mapping space is fully utilized until a slot
    becomes available.
    
    With kmap_local_page() the mappings are per thread, CPU local, can take
    page faults, and can be called from any context (including interrupts). 
    It is faster than kmap() in kernels with HIGHMEM enabled.  Furthermore,
    the tasks can be preempted and, when they are scheduled to run again, the
    kernel virtual addresses are restored and still valid.
    
    Since its use in bnode.c is safe everywhere, it should be preferred.
    
    Therefore, replace kmap() with kmap_local_page() in bnode.c.  Where
    possible, use the suited standard helpers (memzero_page(), memcpy_page())
    instead of open coding kmap_local_page() plus memset() or memcpy().
    
    Tested in a QEMU/KVM x86_32 VM, 6GB RAM, booting a kernel with
    HIGHMEM64GB enabled.
    
    Link: https://lkml.kernel.org/r/20220821180400.8198-3-fmdefrancesco@gmail.comSigned-off-by: default avatarFabio M. De Francesco <fmdefrancesco@gmail.com>
    Suggested-by: default avatarIra Weiny <ira.weiny@intel.com>
    Reviewed-by: default avatarViacheslav Dubeyko <slava@dubeyko.com>
    Cc: Arnd Bergmann <arnd@arndb.de>
    Cc: Chaitanya Kulkarni <kch@nvidia.com>
    Cc: Christian Brauner (Microsoft) <brauner@kernel.org>
    Cc: Damien Le Moal <damien.lemoal@opensource.wdc.com>
    Cc: Jeff Layton <jlayton@kernel.org>
    Cc: Jens Axboe <axboe@kernel.dk>
    Cc: Kees Cook <keescook@chromium.org>
    Cc: Martin K. Petersen <martin.petersen@oracle.com>
    Cc: Matthew Wilcox <willy@infradead.org>
    Cc: Muchun Song <songmuchun@bytedance.com>
    Cc: Roman Gushchin <roman.gushchin@linux.dev>
    Cc: Theodore Ts'o <tytso@mit.edu>
    Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
    ca0ac8df
bnode.c 11.4 KB