• Ben Widawsky's avatar
    drm/i915: mm_list is per VMA · ca191b13
    Ben Widawsky authored
    formerly: "drm/i915: Create VMAs (part 5) - move mm_list"
    
    The mm_list is used for the active/inactive LRUs. Since those LRUs are
    per address space, the link should be per VMx .
    
    Because we'll only ever have 1 VMA before this point, it's not incorrect
    to defer this change until this point in the patch series, and doing it
    here makes the change much easier to understand.
    
    Shamelessly manipulated out of Daniel:
    "active/inactive stuff is used by eviction when we run out of address
    space, so needs to be per-vma and per-address space. Bound/unbound otoh
    is used by the shrinker which only cares about the amount of memory used
    and not one bit about in which address space this memory is all used in.
    Of course to actual kick out an object we need to unbind it from every
    address space, but for that we have the per-object list of vmas."
    
    v2: only bump GGTT LRU in i915_gem_object_set_to_gtt_domain (Chris)
    
    v3: Moved earlier in the series
    
    v4: Add dropped message from v3
    Signed-off-by: default avatarBen Widawsky <ben@bwidawsk.net>
    [danvet: Frob patch to apply and use vma->node.size directly as
    discused with Ben. Also drop a needles BUG_ON before move_to_inactive,
    the function itself has the same check.]
    [danvet 2nd: Rebase on top of the lost "drm/i915: Cleanup more of VMA
    in destroy", specifically unlink the vma from the mm_list in
    vma_unbind (to keep it symmetric with bind_to_vm) instead of
    vma_destroy.]
    Signed-off-by: default avatarDaniel Vetter <daniel.vetter@ffwll.ch>
    ca191b13
i915_drv.h 68.2 KB