• Peter Xu's avatar
    hugetlb: break earlier in add_reservation_in_range() when we can · ca7e0457
    Peter Xu authored
    All the regions maintained in hugetlb reserved map is inclusive on "from"
    but exclusive on "to".  We can break earlier even if rg->from==t because
    it already means no possible intersection.
    
    This does not need a Fixes in all cases because when it happens
    (rg->from==t) we'll not break out of the loop while we should, however the
    next thing we'd do is still add the last file_region we'd need and quit
    the loop in the next round.  So this change is not a bugfix (since the old
    code should still run okay iiuc), but we'd better still touch it up to
    make it logically sane.
    
    Link: https://lkml.kernel.org/r/20210217233547.93892-3-peterx@redhat.comSigned-off-by: default avatarPeter Xu <peterx@redhat.com>
    Reviewed-by: default avatarMike Kravetz <mike.kravetz@oracle.com>
    Reviewed-by: default avatarMiaohe Lin <linmiaohe@huawei.com>
    Cc: Alexey Dobriyan <adobriyan@gmail.com>
    Cc: Andrea Arcangeli <aarcange@redhat.com>
    Cc: Christoph Hellwig <hch@lst.de>
    Cc: Daniel Vetter <daniel@ffwll.ch>
    Cc: David Airlie <airlied@linux.ie>
    Cc: David Gibson <david@gibson.dropbear.id.au>
    Cc: Gal Pressman <galpress@amazon.com>
    Cc: Jan Kara <jack@suse.cz>
    Cc: Jann Horn <jannh@google.com>
    Cc: Jason Gunthorpe <jgg@ziepe.ca>
    Cc: Kirill Shutemov <kirill@shutemov.name>
    Cc: Kirill Tkhai <ktkhai@virtuozzo.com>
    Cc: Matthew Wilcox <willy@infradead.org>
    Cc: Mike Rapoport <rppt@linux.vnet.ibm.com>
    Cc: Roland Scheidegger <sroland@vmware.com>
    Cc: VMware Graphics <linux-graphics-maintainer@vmware.com>
    Cc: Wei Zhang <wzam@amazon.com>
    Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
    Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
    ca7e0457
hugetlb.c 155 KB