• Ian Rogers's avatar
    perf test: Avoid shell test description infinite loop · caaaa554
    Ian Rogers authored
    
    
    for_each_shell_test() is already strict in expecting tests to be files
    and executable. It is sometimes possible when it iterates over all files
    that it finds one that is executable and lacks a newline character. When
    this happens the loop never terminates as it doesn't check for EOF.
    
    Add the EOF check to make this loop at least bounded by the file size.
    
    If the description is returned as NULL then also skip the test.
    Signed-off-by: default avatarIan Rogers <irogers@google.com>
    Cc: Adrian Hunter <adrian.hunter@intel.com>
    Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com>
    Cc: Ingo Molnar <mingo@redhat.com>
    Cc: Jiri Olsa <jolsa@kernel.org>
    Cc: Marco Elver <elver@google.com>
    Cc: Mark Rutland <mark.rutland@arm.com>
    Cc: Namhyung Kim <namhyung@kernel.org>
    Cc: Peter Zijlstra <peterz@infradead.org>
    Cc: Riccardo Mancini <rickyman7@gmail.com>
    Cc: Sohaib Mohamed <sohaib.amhmd@gmail.com>
    Cc: Stephane Eranian <eranian@google.com>
    Link: https://lore.kernel.org/r/20220517204144.645913-1-irogers@google.com
    
    Signed-off-by: default avatarArnaldo Carvalho de Melo <acme@redhat.com>
    caaaa554
builtin-test.c 13.4 KB