• Philipp Stanner's avatar
    drivers/net/ppp: use standard array-copy-function · caf31008
    Philipp Stanner authored
    In ppp_generic.c, memdup_user() is utilized to copy a userspace array.
    This is done without an overflow-check, which is, however, not critical
    because the multiplicands are an unsigned short and struct sock_filter,
    which is currently of size 8.
    
    Regardless, string.h now provides memdup_array_user(), a wrapper for
    copying userspace arrays in a standardized manner, which has the
    advantage of making it more obvious to the reader that an array is being
    copied.
    The wrapper additionally performs an obligatory overflow check, saving
    the reader the effort of analyzing the potential for overflow, and
    making the code a bit more robust in case of future changes to the
    multiplicands len * size.
    
    Replace memdup_user() with memdup_array_user().
    Suggested-by: default avatarDave Airlie <airlied@redhat.com>
    Signed-off-by: default avatarPhilipp Stanner <pstanner@redhat.com>
    Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
    caf31008
ppp_generic.c 85.2 KB