• Eric Biggers's avatar
    blk-crypto: rename blk_keyslot_manager to blk_crypto_profile · cb77cb5a
    Eric Biggers authored
    blk_keyslot_manager is misnamed because it doesn't necessarily manage
    keyslots.  It actually does several different things:
    
      - Contains the crypto capabilities of the device.
    
      - Provides functions to control the inline encryption hardware.
        Originally these were just for programming/evicting keyslots;
        however, new functionality (hardware-wrapped keys) will require new
        functions here which are unrelated to keyslots.  Moreover,
        device-mapper devices already (ab)use "keyslot_evict" to pass key
        eviction requests to their underlying devices even though
        device-mapper devices don't have any keyslots themselves (so it
        really should be "evict_key", not "keyslot_evict").
    
      - Sometimes (but not always!) it manages keyslots.  Originally it
        always did, but device-mapper devices don't have keyslots
        themselves, so they use a "passthrough keyslot manager" which
        doesn't actually manage keyslots.  This hack works, but the
        terminology is unnatural.  Also, some hardware doesn't have keyslots
        and thus also uses a "passthrough keyslot manager" (support for such
        hardware is yet to be upstreamed, but it will happen eventually).
    
    Let's stop having keyslot managers which don't actually manage keyslots.
    Instead, rename blk_keyslot_manager to blk_crypto_profile.
    
    This is a fairly big change, since for consistency it also has to update
    keyslot manager-related function names, variable names, and comments --
    not just the actual struct name.  However it's still a fairly
    straightforward change, as it doesn't change any actual functionality.
    
    Acked-by: Ulf Hansson <ulf.hansson@linaro.org> # For MMC
    Reviewed-by: default avatarMike Snitzer <snitzer@redhat.com>
    Reviewed-by: default avatarMartin K. Petersen <martin.petersen@oracle.com>
    Signed-off-by: default avatarEric Biggers <ebiggers@google.com>
    Link: https://lore.kernel.org/r/20211018180453.40441-4-ebiggers@kernel.orgSigned-off-by: default avatarJens Axboe <axboe@kernel.dk>
    cb77cb5a
dm-core.h 5.53 KB