• Jason A. Donenfeld's avatar
    wireguard: device: reset peer src endpoint when netns exits · 20ae1d6a
    Jason A. Donenfeld authored
    Each peer's endpoint contains a dst_cache entry that takes a reference
    to another netdev. When the containing namespace exits, we take down the
    socket and prevent future sockets from being created (by setting
    creating_net to NULL), which removes that potential reference on the
    netns. However, it doesn't release references to the netns that a netdev
    cached in dst_cache might be taking, so the netns still might fail to
    exit. Since the socket is gimped anyway, we can simply clear all the
    dst_caches (by way of clearing the endpoint src), which will release all
    references.
    
    However, the current dst_cache_reset function only releases those
    references lazily. But it turns out that all of our usages of
    wg_socket_clear_peer_endpoint_src are called from contexts that are not
    exactly high-speed or bottle-necked. For example, when there's
    connection difficulty, or when userspace is reconfiguring the interface.
    And in particular for this patch, when the netns is exiting. So for
    those cases, it makes more sense to call dst_release immediately. For
    that, we add a small helper function to dst_cache.
    
    This patch also adds a test to netns.sh from Hangbin Liu to ensure this
    doesn't regress.
    Tested-by: default avatarHangbin Liu <liuhangbin@gmail.com>
    Reported-by: default avatarXiumei Mu <xmu@redhat.com>
    Cc: Toke Høiland-Jørgensen <toke@redhat.com>
    Cc: Paolo Abeni <pabeni@redhat.com>
    Fixes: 900575aa ("wireguard: device: avoid circular netns references")
    Signed-off-by: default avatarJason A. Donenfeld <Jason@zx2c4.com>
    Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
    20ae1d6a
socket.c 11 KB