• Borislav Petkov's avatar
    ghes, EDAC: Fix ghes_edac registration · cc7f3f13
    Borislav Petkov authored
    Tony reported seeing
    
      "Internal error: Can't find EDAC structure"
    
    when injecting correctable errors due to the fact that ghes_edac would
    still load even if the whitelist won't hit. Drop the pr_err() in
    ghes_edac_report_mem_error() for now due to the hacky way how ghes_edac
    depends on ghes.c.
    
    While at it, make ghes_edac_register() return an error if it doesn't hit
    in the whitelist as it is the only sensible thing to do in that
    situation.
    
    Furthermore, move the call to it to happen last in ghes_probe() so that
    GHES initializing properly does not depend on ghes_edac init at all
    as latter is only reporting errors and not required for GHES's proper
    functioning.
    Reviewed-by: default avatarToshi Kani <toshi.kani@hpe.com>
    Tested-by: default avatarSughosh Ganu <sughosh.ganu@arm.com>
    Signed-off-by: default avatarBorislav Petkov <bp@suse.de>
    Cc: "Rafael J. Wysocki" <rjw@rjwysocki.net>
    Cc: Tony Luck <tony.luck@intel.com>
    Link: https://lkml.kernel.org/r/20180420182015.zao3olss4tvvlxki@agluck-desk
    cc7f3f13
ghes.c 32.2 KB