• Julia Lawall's avatar
    ASoC: constify snd_soc_ops structures · ddba7fa4
    Julia Lawall authored
    Check for snd_soc_ops structures that are only stored in the ops field of a
    snd_soc_dai_link structure.  This field is declared const, so snd_soc_ops
    structures that have this property can be declared as const also.
    
    The semantic patch that makes this change is as follows:
    (http://coccinelle.lip6.fr/)
    
    // <smpl>
    @r disable optional_qualifier@
    identifier i;
    position p;
    @@
    static struct snd_soc_ops i@p = { ... };
    
    @ok1@
    identifier r.i;
    struct snd_soc_dai_link e;
    position p;
    @@
    e.ops = &i@p;
    
    @ok2@
    identifier r.i, e;
    position p;
    @@
    struct snd_soc_dai_link e[] = { ..., { .ops = &i@p, }, ..., };
    
    @bad@
    position p != {r.p,ok1.p,ok2.p};
    identifier r.i;
    struct snd_soc_ops e;
    @@
    e@i@p
    
    @depends on !bad disable optional_qualifier@
    identifier r.i;
    @@
    static
    +const
     struct snd_soc_ops i = { ... };
    // </smpl>
    
    The effect on the layout of the .o files is shown by the following output of
    the size command, first before then after the transformation:
    
      text    data     bss     dec     hex filename
       8748    1024       0    9772    262c sound/soc/fsl/fsl-asoc-card.o
       8812     952       0    9764    2624 sound/soc/fsl/fsl-asoc-card.o
    
       text    data     bss     dec     hex filename
       4165     264       8    4437    1155 sound/soc/fsl/imx-wm8962.o
       4229     200       8    4437    1155 sound/soc/fsl/imx-wm8962.o
    Signed-off-by: default avatarJulia Lawall <Julia.Lawall@lip6.fr>
    Signed-off-by: default avatarMark Brown <broonie@kernel.org>
    ddba7fa4
fsl-asoc-card.c 20 KB