• Chuansheng Liu's avatar
    firmware loader: Fix the race FW_STATUS_DONE is followed by class_timeout · ce2fcbd9
    Chuansheng Liu authored
    There is a race as below when calling request_firmware():
    CPU1                                   CPU2
    write 0 > loading
    mutex_lock(&fw_lock)
    ...
    set_bit FW_STATUS_DONE                 class_timeout is coming
                                           set_bit FW_STATUS_ABORT
    complete_all &completion
    ...
    mutex_unlock(&fw_lock)
    
    In this time, the bit FW_STATUS_DONE and FW_STATUS_ABORT are set,
    and request_firmware() will return failure due to condition in
    _request_firmware_load():
    	if (!buf->size || test_bit(FW_STATUS_ABORT, &buf->status))
    		retval = -ENOENT;
    
    But from the above scenerio, it should be a successful requesting.
    So we need judge if the bit FW_STATUS_DONE is already set before
    calling fw_load_abort() in timeout function.
    
    As Ming's proposal, we need change the timer into sched_work to
    benefit from using &fw_lock mutex also.
    Signed-off-by: default avatarliu chuansheng <chuansheng.liu@intel.com>
    Acked-by: default avatarMing Lei <ming.lei@canonical.com>
    Cc: stable <stable@vger.kernel.org>
    Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
    ce2fcbd9
firmware_class.c 34.1 KB