• Chris Kennelly's avatar
    fs/binfmt_elf: use PT_LOAD p_align values for suitable start address · ce81bb25
    Chris Kennelly authored
    Patch series "Selecting Load Addresses According to p_align", v3.
    
    The current ELF loading mechancism provides page-aligned mappings.  This
    can lead to the program being loaded in a way unsuitable for file-backed,
    transparent huge pages when handling PIE executables.
    
    While specifying -z,max-page-size=0x200000 to the linker will generate
    suitably aligned segments for huge pages on x86_64, the executable needs
    to be loaded at a suitably aligned address as well.  This alignment
    requires the binary's cooperation, as distinct segments need to be
    appropriately paddded to be eligible for THP.
    
    For binaries built with increased alignment, this limits the number of
    bits usable for ASLR, but provides some randomization over using fixed
    load addresses/non-PIE binaries.
    
    This patch (of 2):
    
    The current ELF loading mechancism provides page-aligned mappings.  This
    can lead to the program being loaded in a way unsuitable for file-backed,
    transparent huge pages when handling PIE executables.
    
    For binaries built with increased alignment, this limits the number of
    bits usable for ASLR, but provides some randomization over using fixed
    load addresses/non-PIE binaries.
    
    Tested by verifying program with -Wl,-z,max-page-size=0x200000 loading.
    
    [akpm@linux-foundation.org: fix max() warning]
    [ckennelly@google.com: augment comment]
      Link: https://lkml.kernel.org/r/20200821233848.3904680-2-ckennelly@google.comSigned-off-by: default avatarChris Kennelly <ckennelly@google.com>
    Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
    Cc: Alexander Viro <viro@zeniv.linux.org.uk>
    Cc: Alexey Dobriyan <adobriyan@gmail.com>
    Cc: Song Liu <songliubraving@fb.com>
    Cc: David Rientjes <rientjes@google.com>
    Cc: Ian Rogers <irogers@google.com>
    Cc: Hugh Dickens <hughd@google.com>
    Cc: Suren Baghdasaryan <surenb@google.com>
    Cc: Sandeep Patil <sspatil@google.com>
    Cc: Fangrui Song <maskray@google.com>
    Cc: Nick Desaulniers <ndesaulniers@google.com>
    Cc: "Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>
    Cc: Mike Kravetz <mike.kravetz@oracle.com>
    Cc: Shuah Khan <shuah@kernel.org>
    Link: https://lkml.kernel.org/r/20200820170541.1132271-1-ckennelly@google.com
    Link: https://lkml.kernel.org/r/20200820170541.1132271-2-ckennelly@google.comSigned-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
    ce81bb25
binfmt_elf.c 65.3 KB