• Nicholas Bellinger's avatar
    iser-target: Fix REJECT CM event use-after-free OOPs · ce9a9fc2
    Nicholas Bellinger authored
    This patch fixes a bug in iser-target code where the REJECT CM event
    handler code currently performs a isert_put_conn() for the final
    isert_conn->kref put, while iscsi_np process context is still blocked
    in isert_get_login_rx().
    
    Once isert_get_login_rx() is awoking due to login timeout, iscsi_np
    process context will attempt to invoke iscsi_target_login_sess_out()
    to cleanup iscsi_conn as expected, and calls isert_wait_conn() +
    isert_free_conn() which triggers the use-after-free OOPs.
    
    To address this bug, move the kref_get_unless_zero() call from
    isert_connected_handler() into isert_connect_request() immediately
    preceeding isert_rdma_accept() to ensure the CM handler cleanup
    paths and isert_free_conn() are always operating with two refs.
    
    Cc: Sagi Grimberg <sagig@mellanox.com>
    Cc: <stable@vger.kernel.org> # v3.10+
    Signed-off-by: default avatarNicholas Bellinger <nab@linux-iscsi.org>
    ce9a9fc2
ib_isert.c 91.3 KB