• Greg Kroah-Hartman's avatar
    Revert "char/random: silence a lockdep splat with printk()" · cfc30449
    Greg Kroah-Hartman authored
    This reverts commit 15341b1d which is
    commit 1b710b1b upstream.
    
    Lech writes:
    	After upgrading kernel on our boards from v4.19.105 to v4.19.106
    	we found out that syslog fails to read the messages after ones
    	read initially after opening /proc/kmsg just after booting.
    
    	I also found out, that output of 'dmesg --follow' also doesn't
    	react on new printks appearing for whatever reason - to read new
    	messages, reopening /proc/kmsg or /dev/kmsg was needed.
    
    	I bisected this down to commit
    	15341b1d
    
     ("char/random: silence
    	a lockdep splat with printk()"), and reverting it on top of
    	v4.19.106 restored correct behaviour.
    
    While people dig to find out how such an odd change causes a lockup,
    let's just revert this for now as it's not all that big of a deal for
    4.19.y.
    Reported-by: default avatarLech Perczak <l.perczak@camlintechnologies.com>
    Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
    Cc: Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>
    Cc: Qian Cai <cai@lca.pw>
    Cc: Theodore Ts'o <tytso@mit.edu>
    Cc: Sasha Levin <sashal@kernel.org>
    Cc: Petr Mladek <pmladek@suse.com>
    Cc: John Ogness <john.ogness@linutronix.de>
    Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
    cfc30449
random.c 69.5 KB