• Wending Weng's avatar
    Bluetooth: Fix false errors from bcsp_pkt_cull function · d2e353f7
    Wending Weng authored
    The error message "Removed only %u out of %u pkts" is printed when multiple
    to be acked packets are queued.
    
        if (i++ >= pkts_to_be_removed)
                break;
    
    This will break out of the loop and increase the counter i when
    i==pkts_to_be_removed and the loop ends up with i=pkts_to_be_removed+1.
    
    The following line
    
        if (i != pkts_to_be_removed) {
                BT_ERR("Removed only %u out of %u pkts", i, pkts_to_be_removed);
        }
    
    will then display the false message.
    
    The counter i must not increase on the same statement.
    Signed-off-by: default avatarWending Weng <wweng@rheinmetall.ca>
    Signed-off-by: default avatarMarcel Holtmann <marcel@holtmann.org>
    d2e353f7
hci_bcsp.c 18.4 KB