• Appana Durga Kedareswara rao's avatar
    can: xilinx_can: Fix style issues · d38f9180
    Appana Durga Kedareswara rao authored
    This patch fixes below checkpatch warnings and checks in the driver.
    
    CHECK: Alignment should match open parenthesis
    +       void (*write_reg)(const struct xcan_priv *priv, enum xcan_reg reg,
    +                       u32 val);
    
    CHECK: Alignment should match open parenthesis
    +static void xcan_write_reg_le(const struct xcan_priv *priv, enum xcan_reg reg,
    +                       u32 val)
    
    CHECK: Alignment should match open parenthesis
    +static void xcan_write_reg_be(const struct xcan_priv *priv, enum xcan_reg reg,
    +                       u32 val)
    
    CHECK: Alignment should match open parenthesis
    +       netdev_dbg(ndev, "BRPR=0x%08x, BTR=0x%08x\n",
    +                       priv->read_reg(priv, XCAN_BRPR_OFFSET),
    
    CHECK: Alignment should match open parenthesis
    +                       netdev_warn(ndev,
    +                               "timed out for correct mode\n");
    
    CHECK: Alignment should match open parenthesis
    +       netdev_dbg(ndev, "status:#x%08x\n",
    +                       priv->read_reg(priv, XCAN_SR_OFFSET));
    
    CHECK: spaces preferred around that '-' (ctx:VxV)
    +                       (CAN_EFF_ID_BITS-CAN_SFF_ID_BITS)) <<
                                            ^
    
    CHECK: Alignment should match open parenthesis
    +       netdev_dbg(ndev, "%s: error status register:0x%x\n",
    +                       __func__, priv->read_reg(priv, XCAN_ESR_OFFSET));
    
    WARNING: line over 80 characters
    +                       offset = XCAN_RXMSG_2_FRAME_OFFSET(fsr & XCAN_FSR_RI_MASK);
    
    WARNING: line over 80 characters
    +                       offset = XCAN_RXMSG_FRAME_OFFSET(fsr & XCAN_FSR_RI_MASK);
    
    WARNING: line over 80 characters
    +               while ((isr & XCAN_IXR_TXOK_MASK) && !WARN_ON(++retries == 100)) {
    
    WARNING: line over 80 characters
    +                       priv->write_reg(priv, XCAN_ICR_OFFSET, XCAN_IXR_TXOK_MASK);
    
    CHECK: Alignment should match open parenthesis
    +               netdev_err(ndev, "%s: pm_runtime_get failed(%d)\n",
    +                               __func__, ret);
    
    CHECK: Alignment should match open parenthesis
    +       ret = request_irq(ndev->irq, xcan_interrupt, priv->irq_flags,
    +                       ndev->name, ndev);
    
    CHECK: Alignment should match open parenthesis
    +static int xcan_get_berr_counter(const struct net_device *ndev,
    +                                       struct can_berr_counter *bec)
    
    CHECK: Alignment should match open parenthesis
    +               netdev_err(ndev, "%s: pm_runtime_get failed(%d)\n",
    +                               __func__, ret);
    
    CHECK: Please don't use multiple blank lines
    +
    +
    
    CHECK: Alignment should match open parenthesis
    +               netdev_err(ndev, "%s: pm_runtime_get failed(%d)\n",
    +                       __func__, ret);`
    Signed-off-by: default avatarAppana Durga Kedareswara rao <appana.durga.rao@xilinx.com>
    Signed-off-by: default avatarMarc Kleine-Budde <mkl@pengutronix.de>
    d38f9180
xilinx_can.c 45.9 KB