• Alex Elder's avatar
    net: ipa: don't overrun IPA suspend interrupt registers · d80f8e96
    Alex Elder authored
    In newer hardware, IPA supports more than 32 endpoints.  Some
    registers--such as IPA interrupt registers--represent endpoints
    as bits in a 4-byte register, and such registers are repeated as
    needed to represent endpoints beyond the first 32.
    
    In ipa_interrupt_suspend_clear_all(), we clear all pending IPA
    suspend interrupts by reading all status register(s) and writing
    corresponding registers to clear interrupt conditions.
    
    Unfortunately the number of registers to read/write is calculated
    incorrectly, and as a result we access *many* more registers than
    intended.  This bug occurs only when the IPA hardware signals a
    SUSPEND interrupt, which happens when a packet is received for an
    endpoint (or its underlying GSI channel) that is suspended.  This
    situation is difficult to reproduce, but possible.
    
    Fix this by correctly computing the number of interrupt registers to
    read and write.  This is the only place in the code where registers
    that map endpoints or channels this way perform this calculation.
    
    Fixes: f298ba78 ("net: ipa: add a parameter to suspend registers")
    Signed-off-by: default avatarAlex Elder <elder@linaro.org>
    Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
    d80f8e96
ipa_interrupt.c 7.6 KB