• Ilpo Järvinen's avatar
    Prevent pseudo garbage in SYN's advertized window · d83c9fd4
    Ilpo Järvinen authored
    TCP may advertize up to 16-bits window in SYN packets (no window
    scaling allowed). At the same time, TCP may have rcv_wnd
    (32-bits) that does not fit to 16-bits without window scaling
    resulting in pseudo garbage into advertized window from the
    low-order bits of rcv_wnd. This can happen at least when
    mss <= (1<<wscale) (see tcp_select_initial_window). This patch
    fixes the handling of SYN advertized windows (compile tested
    only).
    
    In worst case (which is unlikely to occur though), the receiver
    advertized window could be just couple of bytes. I'm not sure
    that such situation would be handled very well at all by the
    receiver!? Fortunately, the situation normalizes after the
    first non-SYN ACK is received because it has the correct,
    scaled window.
    
    Alternatively, tcp_select_initial_window could be changed to
    prevent too large rcv_wnd in the first place.
    
    [ tcp_make_synack() has the same bug, and I've added a fix for
      that to this patch -DaveM ]
    Signed-off-by: default avatarIlpo Järvinen <ilpo.jarvinen@helsinki.fi>
    Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
    Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@suse.de>
    d83c9fd4
tcp_output.c 71.9 KB