• Sumit Saxena's avatar
    megaraid_sas: Do not fire MR_DCMD_PD_LIST_QUERY to controllers which do not support it · d9083160
    Sumit Saxena authored
    There was an issue reported by Lucz Geza on Dell Perc 6i. As per issue
    reported, megaraid_sas driver goes into an infinite error reporting loop
    as soon as there is a change in the status of one of the
    arrays (degrade, resync online etc ).  Below are the error logs reported
    continuously-
    
    Jun 25 08:49:30 ns8 kernel: [  757.757017] megaraid_sas 0000:02:00.0: DCMD failed/not supported by firmware: megasas_get_pd_list 4115
    Jun 25 08:49:30 ns8 kernel: [  757.778017] megaraid_sas 0000:02:00.0: DCMD failed/not supported by firmware: megasas_get_pd_list 4115
    Jun 25 08:49:30 ns8 kernel: [  757.799017] megaraid_sas 0000:02:00.0: DCMD failed/not supported by firmware: megasas_get_pd_list 4115
    Jun 25 08:49:30 ns8 kernel: [  757.820018] megaraid_sas 0000:02:00.0: DCMD failed/not supported by firmware: megasas_get_pd_list 4115
    Jun 25 08:49:30 ns8 kernel: [  757.841018] megaraid_sas 0000:02:00.0: DCMD failed/not supported by firmware: megasas_get_pd_list 4115
    
    This issue is very much specific to controllers which do not support
    DCMD- MR_DCMD_PD_LIST_QUERY.  In case of any hotplugging/rescanning of
    drives, AEN thread will be scheduled by driver and fire DCMD-
    MR_DCMD_PD_LIST_QUERY and if this DCMD is failed then driver will fail
    this event processing and will not go ahead for further events. This
    will cause infinite loop of same event getting retried infinitely and
    causing above mentioned logs.
    
    Fix for this problem is: not to fire DCMD MR_DCMD_PD_LIST_QUERY for
    controllers which do not support it and send DCMD SUCCESS status to AEN
    function so that it can go ahead with other event processing.
    Reported-by: default avatarLucz Geza <geza@lucz.com>
    Cc: <stable@vger.kernel.org>
    Signed-off-by: default avatarSumit Saxena <sumit.saxena@broadcom.com>
    Reviewed-by: default avatarTomas Henzl <thenzl@redhat.com>
    Signed-off-by: default avatarMartin K. Petersen <martin.petersen@oracle.com>
    d9083160
megaraid_sas_base.c 197 KB