• Namhyung Kim's avatar
    perf lock contention: Clear lock addr after use · d99317f2
    Namhyung Kim authored
    
    
    It checks the current lock to calculated the delta of contention time.
    The address is saved in the tstamp map which is allocated at begining of
    contention and released at end of contention.
    
    But it's possible for bpf_map_delete_elem() to fail.  In that case, the
    element in the tstamp map kept for the current lock and it makes the
    next contention for the same lock tracked incorrectly.  Specificially
    the next contention begin will see the existing element for the task and
    it'd just return.  Then the next contention end will see the element and
    calculate the time using the timestamp for the previous begin.
    
    This can result in a large value for two small contentions happened from
    time to time.  Let's clear the lock address so that it can be updated
    next time even if the bpf_map_delete_elem() failed.
    Signed-off-by: default avatarNamhyung Kim <namhyung@kernel.org>
    Acked-by: default avatarIan Rogers <irogers@google.com>
    Cc: Hao Luo <haoluo@google.com>
    Cc: Song Liu <song@kernel.org>
    Cc: bpf@vger.kernel.org
    Link: https://lore.kernel.org/r/20231020204741.1869520-1-namhyung@kernel.org
    d99317f2
lock_contention.bpf.c 11 KB