• Mike Snitzer's avatar
    dm crypt: avoid accessing uninitialized tasklet · d9a02e01
    Mike Snitzer authored
    When neither "no_read_workqueue" nor "no_write_workqueue" are enabled,
    tasklet_trylock() in crypt_dec_pending() may still return false due to
    an uninitialized state, and dm-crypt will unnecessarily do io completion
    in io_queue workqueue instead of current context.
    
    Fix this by adding an 'in_tasklet' flag to dm_crypt_io struct and
    initialize it to false in crypt_io_init(). Set this flag to true in
    kcryptd_queue_crypt() before calling tasklet_schedule(). If set
    crypt_dec_pending() will punt io completion to a workqueue.
    
    This also nicely avoids the tasklet_trylock/unlock hack when tasklets
    aren't in use.
    
    Fixes: 8e14f610 ("dm crypt: do not call bio_endio() from the dm-crypt tasklet")
    Cc: stable@vger.kernel.org
    Reported-by: default avatarHou Tao <houtao1@huawei.com>
    Suggested-by: default avatarIgnat Korchagin <ignat@cloudflare.com>
    Reviewed-by: default avatarIgnat Korchagin <ignat@cloudflare.com>
    Signed-off-by: default avatarMike Snitzer <snitzer@kernel.org>
    d9a02e01
dm-crypt.c 95 KB