• Uwe Kleine-König's avatar
    pwm: stm32: Fix calculation of prescaler · dab8f9f0
    Uwe Kleine-König authored
    A small prescaler is beneficial, as this improves the resolution of the
    duty_cycle configuration. However if the prescaler is too small, the
    maximal possible period becomes considerably smaller than the requested
    value.
    
    One situation where this goes wrong is the following: With a parent
    clock rate of 208877930 Hz and max_arr = 0xffff = 65535, a request for
    period = 941243 ns currently results in PSC = 1. The value for ARR is
    then calculated to
    
    	ARR = 941243 * 208877930 / (1000000000 * 2) - 1 = 98301
    
    This value is bigger than 65535 however and so doesn't fit into the
    respective register field. In this particular case the PWM was
    configured for a period of 313733.4806027616 ns (with ARR = 98301 &
    0xffff). Even if ARR was configured to its maximal value, only period =
    627495.6861167669 ns would be achievable.
    
    Fix the calculation accordingly and adapt the comment to match the new
    algorithm.
    
    With the calculation fixed the above case results in PSC = 2 and so an
    actual period of 941229.1667195285 ns.
    
    Fixes: 8002fbee ("pwm: stm32: Calculate prescaler with a division instead of a loop")
    Signed-off-by: default avatarUwe Kleine-König <u.kleine-koenig@baylibre.com>
    Link: https://lore.kernel.org/r/b4d96b79917617434a540df45f20cb5de4142f88.1718979150.git.u.kleine-koenig@baylibre.comSigned-off-by: default avatarUwe Kleine-König <ukleinek@kernel.org>
    dab8f9f0
pwm-stm32.c 20.6 KB