• Waiman Long's avatar
    blk-cgroup: Flush stats at blkgs destruction path · dae590a6
    Waiman Long authored
    As noted by Michal, the blkg_iostat_set's in the lockless list
    hold reference to blkg's to protect against their removal. Those
    blkg's hold reference to blkcg. When a cgroup is being destroyed,
    cgroup_rstat_flush() is only called at css_release_work_fn() which is
    called when the blkcg reference count reaches 0. This circular dependency
    will prevent blkcg from being freed until some other events cause
    cgroup_rstat_flush() to be called to flush out the pending blkcg stats.
    
    To prevent this delayed blkcg removal, add a new cgroup_rstat_css_flush()
    function to flush stats for a given css and cpu and call it at the blkgs
    destruction path, blkcg_destroy_blkgs(), whenever there are still some
    pending stats to be flushed. This will ensure that blkcg reference
    count can reach 0 ASAP.
    Signed-off-by: default avatarWaiman Long <longman@redhat.com>
    Acked-by: default avatarTejun Heo <tj@kernel.org>
    Link: https://lore.kernel.org/r/20221105005902.407297-4-longman@redhat.comSigned-off-by: default avatarJens Axboe <axboe@kernel.dk>
    dae590a6
blk-cgroup.c 53.5 KB